Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep support for python 3.6 and 3.7 #811

Closed
wants to merge 1 commit into from

Conversation

woutdenolf
Copy link

@woutdenolf woutdenolf commented Jun 11, 2024

Related to #810

Breaking changes were introduced here: #808

Overview of build issues: #810 (comment)

I'm not sure how to build locally (make build fails because pyyaml_build_config is only added in CI?) so I didn't test this PR.

Alternatively to this PR: nuke 6.0.2rc1 on pypi and drop support for python 3.6 and 3.7

@woutdenolf woutdenolf marked this pull request as ready for review June 11, 2024 22:36
@@ -33,17 +33,17 @@ def current(cls):


def _expose_config_settings(real_method, *args, **kwargs):
from contextlib import nullcontext
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nullcontext was introduced in python 3.7

@@ -270,7 +270,7 @@ def build_extensions(self):
if with_ext is not None and not with_ext:
continue
if with_cython:
print(f"BUILDING CYTHON EXT; {self.include_dirs=} {self.library_dirs=} {self.define=}")
Copy link
Author

@woutdenolf woutdenolf Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this f-string syntax was introduced in python 3.8

@nitzmahone
Copy link
Member

Yeah, I realized I hadn't yet fixed the metadata to properly signal lack of 3.6 and 3.7 support right after I did 6.0.2rc1. Other than the ability to build the libyaml extension with Cython 3.x, there shouldn't be any "interesting" features or bugfixes in 6.0.2 over 6.0.1, so I'm much more likely to just fix the metadata in a 6.0.2rc2 and yank 6.0.1rc1 at the same time (so 3.6/3.7 users will continue to get 6.0.1 forever).

@PraveenPenguin
Copy link

Yeah, I realized I hadn't yet fixed the metadata to properly signal lack of 3.6 and 3.7 support right after I did 6.0.2rc1. Other than the ability to build the libyaml extension with Cython 3.x, there shouldn't be any "interesting" features or bugfixes in 6.0.2 over 6.0.1, so I'm much more likely to just fix the metadata in a 6.0.2rc2 and yank 6.0.1rc1 at the same time (so 3.6/3.7 users will continue to get 6.0.1 forever).

@nitzmahone any outlook on this when we have a fix on this as we are facing an issue due to this while using one framework

avocado-framework/avocado#5975

@nitzmahone
Copy link
Member

Now that Python 3.13.0rc1 has been tagged, PyYAML 6.0.2 final should be out within the next several days, at which point I'll yank 6.0.2rc1. For now, just don't install with --pre.

@nitzmahone
Copy link
Member

6.0.2 released with corrected python_requires metadata to exclude < 3.8, and the erroneous 6.0.2rc1 has been yanked, so further --pre installs should continue to work on EoL Pythons.

@nitzmahone nitzmahone closed this Aug 6, 2024
@woutdenolf
Copy link
Author

I can confirm this solved the issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants